diff --git a/tests/manual/tickets/189/1.html b/tests/manual/tickets/189/1.html new file mode 100644 index 0000000..944d581 --- /dev/null +++ b/tests/manual/tickets/189/1.html @@ -0,0 +1,14 @@ +

Plain editor

+
+

Content of the editor.

+
+ +

Editor in a bootstrap modal

+ + + diff --git a/tests/manual/tickets/189/1.js b/tests/manual/tickets/189/1.js new file mode 100644 index 0000000..9f714ed --- /dev/null +++ b/tests/manual/tickets/189/1.js @@ -0,0 +1,21 @@ +/** + * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved. + * For licensing, see LICENSE.md. + */ + +/* globals document, window, console */ + +import BalloonEditor from '@ckeditor/ckeditor5-editor-balloon/src/ballooneditor'; +import ArticlePluginSet from '@ckeditor/ckeditor5-core/tests/_utils/articlepluginset'; + +BalloonEditor + .create( document.querySelector( '#editor' ), { + plugins: [ ArticlePluginSet ], + toolbar: [ 'bold', 'link' ] + } ) + .then( editor => { + window.editor = editor; + } ) + .catch( err => { + console.error( err.stack ); + } ); diff --git a/tests/manual/tickets/189/1.md b/tests/manual/tickets/189/1.md new file mode 100644 index 0000000..4d26403 --- /dev/null +++ b/tests/manual/tickets/189/1.md @@ -0,0 +1,9 @@ +## The -webkit-appearance of the buttons in the Bootstrap 4 modal [#189](https://github.com/ckeditor/ckeditor5-theme-lark/issues/189) + +1. Click the link in the content of the **plain editor**. +2. Click the link in the content of the **editor inside the bootstrap modal**. +3. In both cases, the link editing UI should show up. + +**Expected** + +In both cases, all buttons (including the link preview) should look **exactly the same**. diff --git a/tests/manual/tickets/189/assets/iframe-content.html b/tests/manual/tickets/189/assets/iframe-content.html new file mode 100644 index 0000000..fc2be7c --- /dev/null +++ b/tests/manual/tickets/189/assets/iframe-content.html @@ -0,0 +1,58 @@ +
+
+ +
+ +
+ There is nothing to do here as it is just a sub-component of another test. +
+ Click here to continue testing. +
+ + + + + + + + + diff --git a/tests/manual/tickets/189/assets/iframe-content.js b/tests/manual/tickets/189/assets/iframe-content.js new file mode 100644 index 0000000..42f8f9a --- /dev/null +++ b/tests/manual/tickets/189/assets/iframe-content.js @@ -0,0 +1,32 @@ +/** + * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved. + * For licensing, see LICENSE.md. + */ + +/* globals document, window, console, $ */ + +import BalloonEditor from '@ckeditor/ckeditor5-editor-balloon/src/ballooneditor'; +import ArticlePluginSet from '@ckeditor/ckeditor5-core/tests/_utils/articlepluginset'; + +// Display an info when this file is ran as a standalone test. +if ( window.top === window ) { + document.getElementById( 'info' ).style.display = 'block'; +} else { + BalloonEditor + .create( document.querySelector( '#editor' ), { + plugins: [ ArticlePluginSet ], + toolbar: [ 'bold', 'link' ] + } ) + .then( editor => { + window.editor = editor; + + $( '#modal' ).modal( { + // Make sure the modal does not steal the input focus (e.g. when editing a link). + // https://github.com/ckeditor/ckeditor5/issues/1147 + focus: false + } ); + } ) + .catch( err => { + console.error( err.stack ); + } ); +} diff --git a/tests/manual/tickets/189/assets/iframe-content.md b/tests/manual/tickets/189/assets/iframe-content.md new file mode 100644 index 0000000..e69de29 diff --git a/theme/ckeditor5-ui/components/button/button.css b/theme/ckeditor5-ui/components/button/button.css index 5963e00..da304ce 100644 --- a/theme/ckeditor5-ui/components/button/button.css +++ b/theme/ckeditor5-ui/components/button/button.css @@ -37,6 +37,9 @@ a.ck.ck-button { /* Apply some smooth transition to the box-shadow. */ transition: box-shadow 200ms ease-in-out; + /* https://github.com/ckeditor/ckeditor5-theme-lark/issues/189 */ + -webkit-appearance: none; + &:active, &:focus { @mixin ck-focus-ring;