Skip to content
This repository has been archived by the owner on Nov 16, 2017. It is now read-only.

Bring EditorUI (controller) back #109

Closed
pjasiun opened this issue Nov 9, 2016 · 1 comment
Closed

Bring EditorUI (controller) back #109

pjasiun opened this issue Nov 9, 2016 · 1 comment

Comments

@pjasiun
Copy link

pjasiun commented Nov 9, 2016

There are some reasons to have editor UI controller class:

  • some methods and properties like _createEditableUIView, get editableElement(), featureComponents does not belong to the view, they could be moved to the Editor main controller, but then it would handle too much,
  • engine bring its controllers, so UI could do it too, it would create a nice separation where there are separated controllers to handle engine and UI and the main Editor class only bind these pieces together,
  • the editor API for plugins should be well defined, so every developer should know what classes/properties should be brought to make plugins works fine with his editor. The View should not be a part of such API, so featureComponents should be defined in a better place.
@Reinmar
Copy link
Member

Reinmar commented Nov 18, 2016

DUP of #119.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants