-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make limiter element more configurable #5381
Comments
What if For sure, having a limiter element is important as it covers many scenarios. Still, we may need to eventually provide configurable padding somehow, in the |
Since https://github.com/ckeditor/ckeditor5-utils/issues/157, you can define All we need is to enable this thing for limiter: () => {
const limiterRect = new Rect( limiterElementInDOM );
const stickyHeaderRect = new Rect( stickyHeaderInDOM );
// Adjust the limiterRect to consider the stickyHeader. We could even
// introduce some sugar like Rect#substract() similar to existing Rect#getIntersection()
limiterRect.top += stickyHeaderRect.height;
limiterRect.height -= stickyHeaderRect.height;
// etc.
return limtierRect;
}
It would fail to meet more complex scenario requirements very soon. Then we'd be back exactly where we started. With the functional
paddings would do no good but it's trivial case for |
We need to:
|
Feature: Allowed `BalloonPanelView` position limiter defined as a function. Made `ContextualBalloon` position limiter configurable via `#positionLimiter` property. Closes #260.
Let's assume that someone has a sticky header over the editable, and doesn't want to show BPV over the header and doesn't want to hide BPV under the header.
There is no way to add sticky header height to the limiter top offset.
The text was updated successfully, but these errors were encountered: