Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon Toolbar sample does not work #5474

Closed
pjasiun opened this issue Jul 4, 2018 · 4 comments · Fixed by ckeditor/ckeditor5-ui#425
Closed

Balloon Toolbar sample does not work #5474

pjasiun opened this issue Jul 4, 2018 · 4 comments · Fixed by ckeditor/ckeditor5-ui#425
Assignees
@oskarwrobel
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 19

Comments

@pjasiun
Copy link

pjasiun commented Jul 4, 2018

screen shot 2018-07-04 at 17 43 51
@pjasiun
Copy link
Author

pjasiun commented Jul 4, 2018 •
edited
Loading

This the error you see when you open the sample.

@oleq
Copy link
Member

oleq commented Jul 4, 2018 •
edited
Loading

This is because editableElement is null. Can you check this out @oskarwrobel?

It's probably as simple as moving FT#add() to Plugin#init().

@oskarwrobel oskarwrobel self-assigned this Jul 4, 2018
@oskarwrobel
Copy link
Contributor

It's probably as simple as moving FT#add() to Plugin#init().

👍

@oskarwrobel
Copy link
Contributor

Related https://github.com/ckeditor/ckeditor5-core/issues/137.

oleq referenced this issue in ckeditor/ckeditor5-ui Jul 5, 2018
@oleq
Merge pull request #425 from ckeditor/t/424
ae9fa09 
Fix: The `BlockToolbar` should add elements to the `FocusTracker` only after `uiReady` is fired to avoid errors. Closes #424.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 19 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 19
Development

Successfully merging a pull request may close this issue.

Used editableElement after uiReady ckeditor/ckeditor5-ui
4 participants
@oskarwrobel @oleq @pjasiun @mlewand