Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an option to replace getInsertionPosition with a custom position #2813

Closed
ma2ciek opened this issue Jul 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#46
Closed

Provide an option to replace getInsertionPosition with a custom position #2813

ma2ciek opened this issue Jul 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#46
Assignees
@ma2ciek
Labels
package:upload type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 11

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Jul 13, 2017

It would be useful having ability to replace getInsertionPosition( doc ) with a custom position: options.insertionPosition, that would come from the ImageUploadCommand#execute event listener with a higher priority. That'll allow user to provide a custom logic for a place for uploaded image.
@ma2ciek ma2ciek changed the title Provide an option to replace getInsertionPosition with a custom postion Provide an option to replace getInsertionPosition with a custom position Jul 13, 2017
@ma2ciek ma2ciek self-assigned this Jul 13, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-upload Jul 14, 2017
@Reinmar
Merge pull request #46 from ckeditor/t/45
b90c8d7 
Feature: The `ImageUploadCommand` now accepts `insertAt` position which allows customizing where the image will be inserted. Closes #45.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-upload Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:upload labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:upload type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Provide an option to change insertion position of uploaded image ckeditor/ckeditor5-upload
2 participants
@ma2ciek @mlewand