Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include "space" in parseKeystroke() helper function #4965

Closed
oleq opened this issue Jul 5, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#170
Closed

Include "space" in parseKeystroke() helper function #4965

oleq opened this issue Jul 5, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#170
Assignees
@oleq
Labels
package:utils type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented Jul 5, 2017

It looks like it has never been necessary until ckeditor/ckeditor5-ui#265.
@oleq oleq self-assigned this Jul 5, 2017
@oleq oleq changed the title Include "space" in getCode helper function Include "space" in parseKeystroke() helper function Jul 5, 2017
oleq referenced this issue in ckeditor/ckeditor5-utils Jul 5, 2017
@oleq
Internal: Added support for 'space' key code in parseKeystroke() help…
d341e9d 
…er. Closes #169.
oleq referenced this issue in ckeditor/ckeditor5-ui Jul 5, 2017
@oleq
Used 'Space' instead of a number as a keystroke description (requires…
4bbe0b1 
… ckeditor/ckeditor5-utils#169).
Reinmar referenced this issue in ckeditor/ckeditor5-utils Jul 5, 2017
@Reinmar
Merge pull request #170 from ckeditor/t/169
f86b1ad 
Feature: Added support for `'space'` key code in the `parseKeystroke()` helper. Closes #169.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:utils labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:utils type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/169: Added support for 'space' key code in parseKeystroke() helper ckeditor/ckeditor5-utils
2 participants
@oleq @mlewand