Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should EmitterMixin check for undefined callbacks #4984

Closed
jodator opened this issue Nov 17, 2017 · 1 comment
Closed

Should EmitterMixin check for undefined callbacks #4984

jodator opened this issue Nov 17, 2017 · 1 comment
Labels
package:utils resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:question This issue asks a question (how to...).

Comments

@jodator
Copy link
Contributor

jodator commented Nov 17, 2017

Currently such test will fail:

it( 'should not fail on empty callback', () => {
	listener.listenTo( emitter, 'foo' );

	emitter.fire( 'foo' );
	emitter.fire( 'foo:bar' );
} );

As passing undefined here is wrong anyway should we check callback in listenTo() and simply ignoring it?

@Reinmar
Copy link
Member

Reinmar commented Sep 2, 2019

It could :) The same for a couple thousands other methods :D

@Reinmar Reinmar closed this as completed Sep 2, 2019
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:question This issue asks a question (how to...). package:utils labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:utils resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:question This issue asks a question (how to...).
Projects
None yet
Development

No branches or pull requests

3 participants