Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long keystrokes in getEnvKeystrokeText are broken on Mac #4986

Closed
oleq opened this issue Nov 22, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#207
Closed

Long keystrokes in getEnvKeystrokeText are broken on Mac #4986

oleq opened this issue Nov 22, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#207
Assignees
@oleq
Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@oleq
Copy link
Member

oleq commented Nov 22, 2017

  1. The getEnvKeystrokeText supports FOO+BAR keystrokes on Mac only at this moment. When FOO+BAR+BAZ (e.g. CTRL+SHIFT+X) is passed the last segment is ignored (outputs ⌘SHIFT).
  2. The getEnvKeystrokeText should convert "shift" to ⇧ on Mac.
  3. The result should be ⌘⇧ X on Mac and Ctrl+Shift+X on other OSs.

A follow-up of https://github.com/ckeditor/ckeditor5-basic-styles/pull/58/files#r152160035.
@oleq oleq changed the title Advanced keystrokes in getEnvKeystrokeText are broken on Mac Long keystrokes in getEnvKeystrokeText are broken on Mac Nov 22, 2017
oleq referenced this issue in ckeditor/ckeditor5-utils Nov 22, 2017
@oleq
Fix: Long keystrokes should be handled properly by getEnvKeystrokeTex…
5fda7a7 
…t on Mac. Added support for ⇧ and ⌥ modifiers. Closes #206.
@oleq oleq self-assigned this Nov 22, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-utils Nov 23, 2017
@szymonkups
Merge pull request #207 from ckeditor/t/206
d8443e2 
Fix: Long keystrokes should be handled properly by getEnvKeystrokeText on Mac. Added support for ⇧ and ⌥ modifiers. Closes #206.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:utils labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

t/206: Long keystrokes should be handled properly by getEnvKeystrokeText ckeditor/ckeditor5-utils
2 participants
@oleq @mlewand