Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: It should be possible to skip some elements when binding collections #4990

Closed
oskarwrobel opened this issue Jan 8, 2018 · 4 comments · Fixed by ckeditor/ckeditor5-utils#216
Closed

Regression: It should be possible to skip some elements when binding collections #4990

oskarwrobel opened this issue Jan 8, 2018 · 4 comments · Fixed by ckeditor/ckeditor5-utils#216
Assignees
@oskarwrobel
Labels
package:utils type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 14

Comments

@oskarwrobel
Copy link
Contributor

Introduced here: https://github.com/ckeditor/ckeditor5-ui/issues/92.

collectionA.bindTo( collectionB ).using( item => {
    if ( item.hidden ) {
        return null;
    }

    return new Something( item );
} );
@oskarwrobel oskarwrobel self-assigned this Jan 8, 2018
@oskarwrobel oskarwrobel changed the title Regression: It should be possible to skip some element on bound collections Regression: It should be possible to skip some elements when binding collections Jan 8, 2018
@Reinmar
Copy link
Member

Reinmar commented Jan 9, 2018

Introduced here: ckeditor/ckeditor5-ui#92.

But it's an open ticket. Did it have some PRs?

@oskarwrobel
Copy link
Contributor Author

Didn't notice it's open :). AFAIK there is no PRs for the https://github.com/ckeditor/ckeditor5-ui/issues/92. I'm closing this ticket as a DUP.

@oskarwrobel
Copy link
Contributor Author

But... This ticket is in the right repo :)

@oskarwrobel oskarwrobel reopened this Jan 9, 2018
@oskarwrobel
Copy link
Contributor Author

This PR ckeditor/ckeditor5-utils#216 will close both (ui and utils) tickets.

pjasiun referenced this issue in ckeditor/ckeditor5-utils Jan 9, 2018
Merge pull request #216 from ckeditor/t/215
6e0d063 
Feature: Introduced skipping items when binding collections. Closes #215. Closes https://github.com/ckeditor/ckeditor5-ui/issues/92.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:utils labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:utils type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Feature: Introduced skipping items when binging collections. ckeditor/ckeditor5-utils
3 participants
@Reinmar @oskarwrobel @mlewand