Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The env.mac should be called env.isMac. #4995

Closed
jodator opened this issue Feb 7, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-utils#223
Closed

The env.mac should be called env.isMac. #4995

jodator opened this issue Feb 7, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-utils#223
Assignees
@jodator
Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@jodator
Copy link
Contributor

jodator commented Feb 7, 2018

As in description - boolean values should have is/are prefix.
@jodator jodator self-assigned this Feb 7, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-utils Feb 7, 2018
@Reinmar
Merge pull request #223 from ckeditor/t/222
dc6b226 
Other: Renamed `env.mac` to `env.isMac`. Closes #222.

BREAKING CHANGE: Renamed `env.mac` to `env.isMac`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:utils labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Changed: Rename env.mac to env.isMac. ckeditor/ckeditor5-utils
2 participants
@jodator @mlewand