Keystrokes including ⌘ are not recognised if they don't originate in the KeyObserver

[oleq]

The KeyObserver handles ⌘ as Ctrl correctly. It does not matter if one pressed Ctrl+B or ⌘+B, the right thing is executed e.g. by the KeystrokeHandler. As long as the keystroke was pressed in the editing root (or descendant).

But when it comes to the listeners attached to the UI elements (e.g. link form), there's no KeyObserver underneath. And there's no discovery of the metaKey. So in the UI, Ctrl+B and ⌘+B are in fact different keystrokes.

What we need is a simple fix corresponding to the mentioned code in the KeyObserver and a couple of tests.

diff --git a/src/keyboard.js b/src/keyboard.js
index 83fde50..9652de8 100644
--- a/src/keyboard.js
+++ b/src/keyboard.js
@@ -66,6 +66,7 @@ export function getCode( key ) {
 		keyCode = key.keyCode +
 			( key.altKey ? keyCodes.alt : 0 ) +
 			( key.ctrlKey ? keyCodes.ctrl : 0 ) +
+			( key.metaKey ? keyCodes.cmd : 0 ) +
 			( key.shiftKey ? keyCodes.shift : 0 );
 	}

Discovered in ckeditor/ckeditor5-link#190 (comment).

[CKEditorBot]

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).