Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rect#excludeScrollbarsAndBorders should support RTL content #5022

Closed
oleq opened this issue Aug 14, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-utils#298
Closed

Rect#excludeScrollbarsAndBorders should support RTL content #5022

oleq opened this issue Aug 14, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-utils#298
Assignees
@oleq
Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 27 (v15...

Comments

@oleq
Copy link
Member

oleq commented Aug 14, 2019

When RTL, the scrollbar is on the left-side. When LTR, on the right side. It has an impact on the result.
@oleq oleq self-assigned this Aug 14, 2019
oleq referenced this issue in ckeditor/ckeditor5-utils Aug 14, 2019
@oleq
Fix: Rect#excludeScrollbarsAndBorders should support RTL content. F…
95d5dac 
…ixed incorrect output of the method. Closes #297.
jodator referenced this issue in ckeditor/ckeditor5-utils Sep 9, 2019
@jodator
Merge pull request #298 from ckeditor/t/297
35f34fc 
Fix: `Rect#excludeScrollbarsAndBorders` should support RTL environments. Fixed incorrect output of the method. Closes #297.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:utils labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

Successfully merging a pull request may close this issue.

t/297: Fix: Rect#excludeScrollbarsAndBorders should support RTL content ckeditor/ckeditor5-utils
2 participants
@oleq @mlewand