Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strings to set view element's attributes #4582

Closed
szymonkups opened this issue Oct 20, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-widget#27
Closed

Use strings to set view element's attributes #4582

szymonkups opened this issue Oct 20, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-widget#27
Assignees
@szymonkups
Labels
package:widget type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 13

Comments

@szymonkups
Copy link
Contributor

ViewElement's API allows only to set string attributes. We are setting contenteditable attribute to boolean values in couple places. This needs to be fixed.
https://github.com/ckeditor/ckeditor5-widget/blob/1dfdc83c24a6d5c9712e5d93eb7d656f9543091a/src/utils.js#L54
@szymonkups szymonkups self-assigned this Oct 20, 2017
oskarwrobel referenced this issue in ckeditor/ckeditor5-widget Oct 23, 2017
@oskarwrobel
Merge pull request #27 from ckeditor/t/26
d2a6cf5 
Fix: Using strings instead of boolean values in contenteditable attribute. Closes #26.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-widget Oct 9, 2019
@mlewand mlewand added this to the iteration 13 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:widget labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:widget type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 13
Development

Successfully merging a pull request may close this issue.

Fixed setting contenteditable attribute to string instead of boolean. ckeditor/ckeditor5-widget
2 participants
@szymonkups @mlewand