From 24c24fea8cef760d67edc58f64163f23d0d8504a Mon Sep 17 00:00:00 2001 From: Marta Motyczynska Date: Tue, 12 Jul 2022 16:55:42 +0200 Subject: [PATCH 1/2] Fix value for aria-pressed for toggleable button. --- packages/ckeditor5-ui/src/button/buttonview.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ckeditor5-ui/src/button/buttonview.js b/packages/ckeditor5-ui/src/button/buttonview.js index e71a41404cc..71b2262a0f6 100644 --- a/packages/ckeditor5-ui/src/button/buttonview.js +++ b/packages/ckeditor5-ui/src/button/buttonview.js @@ -145,7 +145,7 @@ export default class ButtonView extends View { tabindex: bind.to( 'tabindex' ), 'aria-labelledby': `ck-editor__aria-label_${ ariaLabelUid }`, 'aria-disabled': bind.if( 'isEnabled', true, value => !value ), - 'aria-pressed': bind.to( 'isOn', value => this.isToggleable ? String( value ) : false ) + 'aria-pressed': bind.to( 'isOn', value => this.isToggleable ? String( !!value ) : false ) }, children: this.children, From 723fa78ec45e4027f4f5c30dabb2c631b83c185f Mon Sep 17 00:00:00 2001 From: Marta Motyczynska Date: Wed, 13 Jul 2022 13:00:52 +0200 Subject: [PATCH 2/2] Add test for default value of aria-pressed for toggleable button. --- packages/ckeditor5-ui/tests/button/buttonview.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/ckeditor5-ui/tests/button/buttonview.js b/packages/ckeditor5-ui/tests/button/buttonview.js index 0b0d219e6d3..46c7eb00e62 100644 --- a/packages/ckeditor5-ui/tests/button/buttonview.js +++ b/packages/ckeditor5-ui/tests/button/buttonview.js @@ -262,6 +262,12 @@ describe( 'ButtonView', () => { expect( view.element.attributes[ 'aria-disabled' ].value ).to.equal( 'true' ); } ); + it( '-pressed has correct default value for toggleable button', () => { + view.isToggleable = true; + view.isOn = undefined; + expect( view.element.attributes[ 'aria-pressed' ].value ).to.equal( 'false' ); + } ); + it( '-pressed reacts to #isOn', () => { view.isToggleable = true; view.isOn = true;