Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edge] Can't put the selection inside a table cell #1067

Closed
Mgsy opened this issue Jun 19, 2018 · 8 comments
Closed

[Edge] Can't put the selection inside a table cell #1067

Mgsy opened this issue Jun 19, 2018 · 8 comments
Assignees
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Mgsy
Copy link
Member

Mgsy commented Jun 19, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

πŸ’» Version of CKEditor

Latest master

πŸ“‹ Steps to reproduce

  1. Create new table.
  2. Try to put the selection inside a cell.

βœ… Expected result

It's possible.

❎ Actual result

It's impossible.

πŸ“ƒ Other details that might be useful

GIF

bug_cke5

Other information
OS: Windows 10
Browser: Edge 17

@Mgsy Mgsy changed the title [Edge] Can't put the selection inside th [Edge] Can't put the selection inside a table Jun 19, 2018
@Mgsy Mgsy added the type:bug This issue reports a buggy (incorrect) behavior. label Jun 19, 2018
@Mgsy Mgsy changed the title [Edge] Can't put the selection inside a table [Edge] Can't put the selection inside a table cell Jun 19, 2018
@Reinmar
Copy link
Member

Reinmar commented Jun 19, 2018

Can you type there? I can see the editable gets the blue border. So maybe the issue is that the caret isn't visible?

@Reinmar Reinmar added this to the iteration 19 milestone Jun 19, 2018
@Mgsy
Copy link
Member Author

Mgsy commented Jun 19, 2018

Can you type there? I can see the editable gets the blue border. So maybe the issue is that the caret isn't visible?

Nope, typing is not possible.

@Reinmar
Copy link
Member

Reinmar commented Jun 19, 2018

Damn... This is something we'll need to understand.

@jodator
Copy link
Contributor

jodator commented Jun 20, 2018

I've found that:

  1. model selection is set as expected
  2. view selection is set as expected
  3. DOM selection is set as expected
  4. typing does not work
  5. selection is not visible

Setting contentediable="true" on widget helps.

@jodator
Copy link
Contributor

jodator commented Jun 20, 2018

So this does not work on Edge (you cannot type) inside contenteditable:

<figure contenteditable="false">
	<table>
		<tbody>
			<tr>
				<td contenteditable="true">

while this does:

<figure>
	<table contenteditable="false">
		<tbody>
			<tr>
				<td contenteditable="true">

@Reinmar Reinmar modified the milestones: iteration 18, iteration 19 Jun 20, 2018
@Reinmar
Copy link
Member

Reinmar commented Jun 20, 2018

:/

OK, let's postpone this to it19. I don't think that MS devs will fix it soon so we need to figure out a workaround.

@jodator
Copy link
Contributor

jodator commented Jun 20, 2018

Reported to Microsoft Edge issue tracker.

@jodator
Copy link
Contributor

jodator commented Jun 28, 2018

@Reinmar I'd go with this if it's easy to change:

<figure>
	<table contenteditable="false">
		<tbody>
			<tr>
				<td contenteditable="true">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants