Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing a table with column count changed by another user breaks the RTC #12325

Closed
Dumluregn opened this issue Aug 24, 2022 · 1 comment
Closed
Labels
package:table squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Dumluregn
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Open an RTC demo with table column resize plugin loaded.
  2. Join as a second user.
  3. Resize a table and remove some columns.
  4. Try to resize the table as a second user.

✔️ Expected result

Resizing the table should work normally for both users.

❌ Actual result

The user that didn't delete the columns gets errors while resizing.

❓ Possible solution

That happens because the table state is stored locally in the plugin (`cellIndexMap`) and not updated between the editor instances in RTC.

📃 Other details

  • Browser: all
  • OS: all
  • First affected CKEditor version:
  • Installed CKEditor plugins: table-column-resize

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Dumluregn Dumluregn added type:bug This issue reports a buggy (incorrect) behavior. package:table squad:features Issue to be handled by the Features team. labels Aug 24, 2022
@Dumluregn Dumluregn added this to the iteration 56 milestone Aug 24, 2022
@Dumluregn
Copy link
Contributor Author

Solved with #12288.

@mlewand mlewand changed the title Changing the columns count in a table witch column resize breaks the RTC Changing the columns count in a table with column resize breaks the RTC Aug 24, 2022
@Dumluregn Dumluregn changed the title Changing the columns count in a table with column resize breaks the RTC Resizing a table with column count changed by another user breaks the RTC Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

1 participant