Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable custom elements rendering #12854

Open
Mgsy opened this issue Nov 16, 2022 · 5 comments
Open

Add option to enable custom elements rendering #12854

Mgsy opened this issue Nov 16, 2022 · 5 comments
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:html-support squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Mgsy
Copy link
Member

Mgsy commented Nov 16, 2022

📝 Provide a description of the new feature

The current approach for custom elements is similar to HTML comments - we preserve them in the model and in the data pipeline, but we don't render them in the editing view, so for example, this markup:

<internal>
   <p>Foo</p>
</internal>

is visible in the data:

in the model:

but not in the editing view:

This feature request is about enabling custom elements rendering and editing. 

Some notes from the previous work on bringing support for custom elements: https://github.com/ckeditor/ckeditor5/issues/11432#issuecomment-1103686979 

Kind of related: #12838 


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@Mgsy Mgsy added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). support:2 An issue reported by a commercially licensed client. squad:core Issue to be handled by the Core team. package:html-support labels Nov 16, 2022
@Reinmar Reinmar added the domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. label Mar 20, 2023
@Joshuajrodrigues
Copy link

Joshuajrodrigues commented Aug 24, 2023

any update on this ? i have the same issue but with the "text " element

@Witoso
Copy link
Member

Witoso commented Aug 25, 2023

Handling of custom elements can be defined with General HTML support. I'm not sure what you meant by the "text" element.

@Joshuajrodrigues
Copy link

hey again @Witoso , so for this we reached out to support and were notified that this feature is not available. Basically we are having all our existing data from our old RTEEditor nested in a text tag.

existing data is enclosed in text

hello world

no display
image

without text tag

image

this actually is a big issue as we also use revision history with auto save, so not only is the data not visible but if the user tried to add anything all the data gets replaced

@Joshuajrodrigues
Copy link

Handling of custom elements can be defined with General HTML support. I'm not sure what you meant by the "text" element.

We have actually done this too, by default we are allowing all html with the regex exp for name, still we get nothing

@Witoso
Copy link
Member

Witoso commented Aug 25, 2023

so for this we reached out to support and were notified that this feature is not available.

I would trust support engineers on that. Looks like a complex case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:html-support squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

4 participants