Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] PoC of using types with predefined build #13547

Closed
arkflpc opened this issue Feb 24, 2023 · 2 comments
Closed

[TS] PoC of using types with predefined build #13547

arkflpc opened this issue Feb 24, 2023 · 2 comments
Assignees
Labels
domain:ts squad:core Issue to be handled by the Core team.

Comments

@arkflpc
Copy link
Contributor

arkflpc commented Feb 24, 2023

Part of #13471.

@arkflpc arkflpc added the squad:core Issue to be handled by the Core team. label Feb 24, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Feb 24, 2023
@Witoso
Copy link
Member

Witoso commented Mar 13, 2023

The result of PoC:

  • Project with predefined build based on the alpha.1 release. On ckeditor5 repo in the dedicated branch.
  • Write down how the integration went. What steps happened, etc. what was not obvious, did it help, in what, we could later reuse it in guides for this dedicated technology and in TS blog post.

@filipsobol filipsobol self-assigned this Mar 22, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Mar 22, 2023
@filipsobol
Copy link
Member

I have added demo of predefined builds to the ck/13549-build-from-source-typescript branch (created for #13549). Since types will not be available for CDN builds and the online builder is not yet updated, I only tested the "npm install" path.
 

First, I setup a new Vite project using the following command:

npm create vite@latest predefined-builds -- --template vanilla-ts

Next I installed alpha versions of all predefined builds:

yarn add @ckeditor/ckeditor5-build-balloon@alpha
yarn add @ckeditor/ckeditor5-build-balloon-block@alpha
yarn add @ckeditor/ckeditor5-build-classic@alpha
yarn add @ckeditor/ckeditor5-build-decoupled-document@alpha
yarn add @ckeditor/ckeditor5-build-inline@alpha

Then, it was just matter of importing each build and calling the create method like in the documentation.

 

I created two issues for QoL improvements we could introduce (first, second), but overall the suggestions for editor configuration and on Editor instance worked well.

@arkflpc arkflpc closed this as completed Mar 27, 2023
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 27, 2023
@CKEditorBot CKEditorBot added this to the upcoming milestone Mar 27, 2023
@Reinmar Reinmar modified the milestones: upcoming, iteration 61 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ts squad:core Issue to be handled by the Core team.
Projects
None yet
Development

No branches or pull requests

5 participants