-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TextTransformation in all builds? #1843
Comments
What's the size difference in KB (gzipped) in the classic build? |
Side note on such questions: creating an online builder - that was discussed somewhere already - could help us solving such issues. I think that having such tools would allow us to see what people are adding/removing to/from builds. |
I'd sync this change with #1844, so postponing. |
Results without and with this plugin:
|
But I checked its popularity and I'd say it's similar to that of mentions, word count, remove formatting, etc. So why not add the other ones too? From a different perspective, the text transformation feature adds a "nice touch" and should be well received by people who care about typography. But for them to notice it, it'd have to be enabled by default. And that's quite a significant change. I'd say it's a breaking change because this is a quite intrusive plugin. Also, I think the plugin is far from ideal. The transformations should be localized – different languages have different typographical solutions. This plugin isn't awere of that. It also doesn't handle well the situation when the user want to revert the transformation (the plugin is stubborn and will fix your text infinitely). That was reported to us, in fact. So, there are two options:
|
@Reinmar: Could you explain this more? How this happens? You should be able to undo a transformation after it happens. After that should be able to type and the text should remain unfixed. |
I think one of our customers was reporting this (when used with autocapitalization transformation, but applies to other ones too):
|
Well, this case cannot be detected as "undoing" easily. typing
Same steps - different expectations. I think that Undo is a way to go and Backspace shouldn't block the next transformation. |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it). |
Once we have a confirmation that this feature works reliably with the variety of our plugins and integrations, it'd most likely make sense to enable it by default.
The downsides:
Arguments for:
Discuss :D
The text was updated successfully, but these errors were encountered: