Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent error when testing bundled editor #310

Closed
Reinmar opened this issue Aug 22, 2016 · 1 comment
Closed

Silent error when testing bundled editor #310

Reinmar opened this issue Aug 22, 2016 · 1 comment

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2016

There's an ugly issue when trying to run tests for bundled editor.

First, I get error here:

It's super strange, because when I stop debugger at that error, the variable doesn't seem to be undefined ;|.

Second, since that failed, loading CKEditorError which is needed to extend chai fails too.

This is really weird from the very beginning, because there's no difference between bundled and not bundled test. But it made me realise something different – that chai's extension is not going to work in tests with bundled editors, because the bundle contains a different instance of that class than what require.js loads.

So, I decided to not extend chain in those specific tests... but how to achieve that? I've got no idea. Bender doesn't give me the test config, so I cannot execute this code conditionally. Plus, why the code fails in the first place? :|

@Reinmar
Copy link
Member Author

Reinmar commented Aug 23, 2016

We removed the chai extension, so the error is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant