Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider spacing between the content when merging cells #3191

Closed
oleq opened this issue Jun 8, 2018 · 2 comments
Closed

Consider spacing between the content when merging cells #3191

oleq opened this issue Jun 8, 2018 · 2 comments
Assignees
Labels
package:table resolution:cantfix Issue that cannot be fixed due to platform limitations. status:discussion type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Jun 8, 2018

ATM merging cells concatenates the content just like v4:

kapture 2018-06-08 at 17 28 06

However I checked GDocs and Apple Pages and they both insert a <br> between the content of the cells in such situation, which makes more sense to me.

So the idea is:

  1. to simply put a white space between the merged content in the MVP,
  2. break the line like popular word processors when the feature is ready and stable in the editor

Note: Pages add a tab when merging horizontally and a line break when vertically. GDocs always uses a line break.

image

cc @jodator

@jodator
Copy link
Contributor

jodator commented Jun 8, 2018

Yeah... kinda forgot about it. That was just first implementation of this. So anything as small as space will be better then current state.

As for what should be there then as other features this might be handled better after MVP. So generally speaking 👍 for space now and something better later on. As for now the spacer (tab/space) for horizontal and soft break for vertical merge looks interesting.

@jodator jodator self-assigned this Aug 2, 2018
@jodator
Copy link
Contributor

jodator commented Nov 19, 2018

Closing as invalid right now. The table feature has block only content now so merging two cells results in two paragraphs so this issue is not reproducible ATM.

@jodator jodator closed this as completed Nov 19, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added resolution:cantfix Issue that cannot be fixed due to platform limitations. status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:table labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table resolution:cantfix Issue that cannot be fixed due to platform limitations. status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants