Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiveSelection: LiveRanges are not detached correctly. #4036

Closed
scofalik opened this issue Apr 4, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1181
Closed

LiveSelection: LiveRanges are not detached correctly. #4036

scofalik opened this issue Apr 4, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1181
Assignees
@jodator
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@scofalik
Copy link
Contributor

scofalik commented Apr 4, 2017

In https://github.com/ckeditor/ckeditor5-engine/issues/780#issuecomment-291171133 I've found a memory leak in LiveSelection. LiveRange callbacks are not correctly detached.
@jodator
Copy link
Contributor

jodator commented Oct 18, 2017

BTW: ckeditor/ckeditor5-engine#904 (comment) As I wrote in PR rather then in issue.

Reinmar referenced this issue in ckeditor/ckeditor5-engine Dec 11, 2017
@Reinmar
Merge pull request #1181 from ckeditor/t/903-new
7e352e3 
Fix: Fixed memory leak in `DocumentSelection`. Closes #903.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
@scofalik scofalik mentioned this issue Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
3 participants
@jodator @scofalik @mlewand