Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One MoveOperation to move them all #4101

Closed
scofalik opened this issue Jul 5, 2017 · 2 comments
Closed

One MoveOperation to move them all #4101

scofalik opened this issue Jul 5, 2017 · 2 comments
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@scofalik
Copy link
Contributor

scofalik commented Jul 5, 2017

(Follow-up to ckeditor/ckeditor5-engine#977)

At this moment, RemoveOperation and ReinsertOperation only very slightly differ from MoveOperation. Actually, it is just #type, #getReversed(). Additionally, ReinsertOperation has also #position but this is only used by deltas/deltas special cases and could be easily removed.

Additionally, in ckeditor/ckeditor5-engine#977, I introduced "move operation normalization". This means, that when any MoveOperation is transformed by MoveOperation, the resulting operation is not based on original operation's class but is taken from targetPosition and sourcePosition.

This all leds to conclusion, that RemoveOperation and ReinsertOperation are not needed. All we need is MoveOperation that automatically sets #type to a proper value, basing on targetPosition and sourcePosition.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added module:model status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

4 participants