One MoveOperation to move them all #4101
Labels
package:engine
resolution:expired
This issue was closed due to lack of feedback.
status:discussion
status:stale
type:improvement
This issue reports a possible enhancement of an existing feature.
(Follow-up to ckeditor/ckeditor5-engine#977)
At this moment,
RemoveOperation
andReinsertOperation
only very slightly differ fromMoveOperation
. Actually, it is just#type
,#getReversed()
. Additionally,ReinsertOperation
has also#position
but this is only used by deltas/deltas special cases and could be easily removed.Additionally, in ckeditor/ckeditor5-engine#977, I introduced "move operation normalization". This means, that when any
MoveOperation
is transformed byMoveOperation
, the resulting operation is not based on original operation's class but is taken fromtargetPosition
andsourcePosition
.This all leds to conclusion, that
RemoveOperation
andReinsertOperation
are not needed. All we need isMoveOperation
that automatically sets#type
to a proper value, basing ontargetPosition
andsourcePosition
.The text was updated successfully, but these errors were encountered: