-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces inside <code> should be rendered in a normal way #4175
Comments
Maybe it will let us skip looking backward in space-replace algorithm. |
It has nothing to do with that. We just need to remove |
Exactly... apart from styling, I don't see much difference between |
Well, we look back because we assumed that there are elements in which we don't want to convert spaces to |
You might be right that we don't need to look back if we'd assume that previous text node's last space is always converted to nbsp, but this is not related to the |
Okay I won't argue because I don't remember that algorithm and all the cases precisely. |
Fix: Spaces inside `<code>` will be rendered in a normal way (previously `DomConverter` tried to treat `<code>` like a preformatted block which is not what HTML requires). Closes #1126.
We assumed that subsequent spaces must be rendered in "as is" way in
<code>
elements, without encoding them to pairs of "space + nbsp". However, this isn't correct, as we learned in ckeditor/ckeditor5-basic-styles#55 (comment).The text was updated successfully, but these errors were encountered: