Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make model/Writer and view/DowncastWriter more consistent #4419

Closed
f1ames opened this issue Sep 12, 2018 · 3 comments
Closed

Make model/Writer and view/DowncastWriter more consistent #4419

f1ames opened this issue Sep 12, 2018 · 3 comments
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. status:stale

Comments

@f1ames
Copy link
Contributor

f1ames commented Sep 12, 2018

Follow up of #4409:

The only thing which makes me sad about this change is that after it the DowncastWriter.rename() method signature will be inconsistent with the model/writer.rename() method signature. (...) it may bring some confusion for developers who use both model and view writers frequently.

So the purpose of this ticket is to make model/Writer#rename() and view/DowncastWriter#rename() methods signature consistent by changing model/Writer#rename() parameters order.

@Reinmar
Copy link
Member

Reinmar commented Apr 29, 2019

A more specific issue regarding the insertion methods: https://github.com/ckeditor/ckeditor5-engine/issues/1724.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 3, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. status:stale
Projects
None yet
Development

No branches or pull requests

5 participants