Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly confusing API (editor.ui.view.editable.element VS editor.ui.view.editable.editableElement) #5433

Closed
wwalc opened this issue Nov 17, 2017 · 8 comments
Labels
package:ui resolution:expired This issue was closed due to lack of feedback. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:question This issue asks a question (how to...).

Comments

@wwalc
Copy link
Member

wwalc commented Nov 17, 2017

When trying to set an attribute on the editable element in #670 I noticed that there are two attributes which point to the same element (editor.ui.view.editable.element VS editor.ui.view.editable.editableElement). I was immediately confused which one should I choose and if there will be any unexpected implications if I use the wrong one.

@oleq
Copy link
Member

oleq commented Nov 17, 2017

It looks like the editableElement property is no longer needed.

@Reinmar
Copy link
Member

Reinmar commented Nov 17, 2017

editableElement was meant to give you the right element in case of iframed editables.

So, for normal editables, editableElement == element. But for iframes that will be different. element will equal the iframe and editableElement the body inside.

@Reinmar
Copy link
Member

Reinmar commented Nov 17, 2017

We could remove editableElement for now but we'll need to add it one day anyway. And it may be better to have that standard access from the beginning.

@oleq
Copy link
Member

oleq commented Nov 23, 2017

That's a good point. Let's get back to this issue when (if) we develop an iframe–based editor.

@Reinmar
Copy link
Member

Reinmar commented Nov 23, 2017

What we can do now is review these prop API docs. But I know that it will be confusing anyway...

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the unknown milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:question This issue asks a question (how to...). package:ui labels Oct 9, 2019
@pomek pomek removed this from the unknown milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui resolution:expired This issue was closed due to lack of feedback. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:question This issue asks a question (how to...).
Projects
None yet
Development

No branches or pull requests

6 participants