Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Code #5547

Closed
fredck opened this issue Aug 22, 2017 · 14 comments · Fixed by ckeditor/ckeditor5-basic-styles#55
Closed

Inline Code #5547

fredck opened this issue Aug 22, 2017 · 14 comments · Fixed by ckeditor/ckeditor5-basic-styles#55
Assignees
Labels
package:basic-styles type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@fredck
Copy link
Contributor

fredck commented Aug 22, 2017

There should be support for inline code markup, outputting the <code> HTML element.

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2017

We should also think about adding support for codes in the autoformatter. It'd be awesome if it supported `code`.

Another thing is an icon. cc @oleq.

And one last thing is whether all this will work in the engine. We didn't yet check whether preformatted text works for real (although, we anticipated it) and it requires a bit different rendering approach.

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2017

PS. When updating autoformatting, please don't forget to update its docs: https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/features/autoformat.html

@oleq
Copy link
Member

oleq commented Aug 22, 2017

Another thing is an icon. cc @oleq.

Ping me again when things become serious here ;-)

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2017

I'm pinging :D This is queued for @pomek to work on.

@fredck
Copy link
Contributor Author

fredck commented Aug 22, 2017

We didn't yet check whether preformatted text works for real

I would not worry about making it "preformatted" (in the model point of view) right now. A quick implementation that works just like bold and italic would do the job at this stage. A follow-up issue could come if we'll like to make this feature more complex later, so it handles spaces differently.

@oleq
Copy link
Member

oleq commented Aug 22, 2017

I'm pinging :D This is queued for @pomek to work on.

@pomek, ping me when you start dealing get advanced with this issue in your queue ;-)

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2017

I would not worry about making it "preformatted" (in the model point of view) right now. A quick implementation that works just like bold and italic would do the job at this stage. A follow-up issue could come if we'll like to make this feature more complex later, so it handles spaces differently.

If it will turn out that our space rendering algorithm fails to handle <code>, we can indeed disable it for now.

@fredck
Copy link
Contributor Author

fredck commented Aug 22, 2017

Btw, not even GH handles spaces inside inline code... so not sure if we should ever support it.

@fredck
Copy link
Contributor Author

fredck commented Aug 22, 2017

For example, I'm adding 10 spaces inside the quotes here: code( " " )

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2017

LOL... true :D

Anyway, this was taken care of a long time ago, so let's just see if it works.

@pomek pomek self-assigned this Aug 23, 2017
@oleq
Copy link
Member

oleq commented Aug 23, 2017

Icon ideas so far:
image
image

@oleq
Copy link
Member

oleq commented Aug 23, 2017

Some improvements to make them feel more lightweight:
image

@fredck
Copy link
Contributor Author

fredck commented Aug 23, 2017

I like the </> idea... but I prefer even more the GH one, which is just <>, as it looks more balanced, visually.

@oleq
Copy link
Member

oleq commented Aug 23, 2017

Added
image
in ckeditor/ckeditor5-basic-styles@0e797f3.

Reinmar referenced this issue in ckeditor/ckeditor5-basic-styles Sep 8, 2017
Feature: Introduced the `Code` plugin. Closes #52.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-basic-styles Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:basic-styles labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:basic-styles type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants