-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Sample with full features set #5588
Comments
Placement
ContentIt would be nice to present a demo with a lot of features. We will need help from the marketing team for sure. cc @PiotrMaciej Toolbar itemsWhat is more important to show at first? Table or font color? Undo/redo or MediaEmbed? It's a question to you guys, do you have any ideas about improving the order of toolbar items? |
I'm having second doubts here. We've been here in the past – with editors that support everything. It kinda works because it seems that the editor can do everything. But somehow, with time, starting from CKEditor 4.0, we moved in the other direction. Why?
But, at the same time, I completely agree that we have discoverability issues. I'd look for alternative options:
WDYT? |
We could have a mega-build with all the most common/usable features. Not necessarily on features' landing page, but referenced there - should do. As this is virtually impossible to put all the features in it, we could try coming up with more than one - like cooperation oriented (comments and track changes), simplicity oriented (autoformatting etc.). Also: doesn't onlinehtmleditor kinda serve this very purpose? It should be updated with the newest features, sure, but this is a good start. I'm not sure about
Putting a piece of information in each guide about it? The very idea is cool, but I can't really picture the execution. We could easily put it on the main features page once this gets a makeover, but people often bypass it, coming for specific features. Also: do we have an in-editor help button? Or context help? |
There's this, the first serious step toward all-feature demo. https://github.com/cksource/ckeditor5-internal/compare/ck/5588 |
So I gave it another go and after a few rounds of feedback gathering and improvements, here are the two PRs that introduce a full-featured sample:
Still, some TODOs left:
Also all, feel free to propose any improvements that you feel could work. What we can still consider:
|
Pimped the list to be both un/ordered with nested items. |
Also added two really, really inline images in the form of Mario from Super Mario Bros and Link from the Legend of Zelda: Link's Awakening videogame classics. |
I've adjusted the Export to Word and Export to PDF configuration, so the content in the exported documents looks better now. Unfortunately, it would be difficult to keep 1:1, because the editor on the page has a non-standard size and our exports support only predefined sizes (A4, B4 etc.), but I think there's not much we can do about it if we want to keep the editor size. @godai78, I also removed the table caption from the content. It turned out it breaks the docx conversion - cksource/openxml-converter#382. Apart from that, our docx converter doesn't handle aligned images, so the exported content looks different: We need to decide whether we can accept it or change the content. |
How about the inline icons? Are they fine? |
Yep, only aligned images don't display properly. |
We can easily decide to drop them, I'm not gonna fight over these. |
We're going to mention the full-featured editor in today's release blog post, but it means we need to merge it first. Does anyone have any further comments? |
Done in cksource/ckeditor5-internal@04b063d. |
Merged in #10989 and cksource/ckeditor5-internal#1242 |
📝 Provide a description of requested docs changes
Currently, with introduced Responsive toolbar it's worth to consider a "full feature" sample.
At this moment discoverability of editor features is really poor. We don't' have any demo/page with listed features of CKEditor 5, even on our website. The new user is only able to scroll the Features menu on documentation page or check Features section in our README.
It would be much easier to include every single feature in one demo and give users a possibility to "play" with them instead of checking a single dedicated sample/page.
Note: It might be a blocker: #5586.
cc @Reinmar @mlewand @oleq @AnnaTomanek
The text was updated successfully, but these errors were encountered: