Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Crash when removing row after horizontal split #6401

Closed
FilipTokarski opened this issue Mar 10, 2020 · 2 comments
Closed

[Table] Crash when removing row after horizontal split #6401

FilipTokarski opened this issue Mar 10, 2020 · 2 comments
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@FilipTokarski
Copy link
Member

πŸ“ Provide detailed reproduction steps (if any)

  1. Open some test with table
  2. Select some cell and split horizontally two times
  3. Select the middle cell and click delete row

βœ”οΈ Expected result

Row gets deleted

❌ Actual result

Editor crashes:
table_split1

Uncaught TypeError: Cannot read property 'is' of undefined
    at Function._createAt (position.js:914)
    at Model.createPositionAt (model.js:606)
    at Writer.createPositionAt (writer.js:597)
    at Object.callback (removerowcommand.js:103)
    at Model._runPendingChanges (model.js:801)
    at Model.change (model.js:170)
    at RemoveRowCommand.execute (removerowcommand.js:61)
    at RemoveRowCommand.<anonymous> (observablemixin.js:255)
    at RemoveRowCommand.fire (emittermixin.js:209)
    at RemoveRowCommand.<computed> [as execute] (observablemixin.js:259)

πŸ“ƒ Other details

I cannot reproduce it on latest docs, as well as v16 & v15. After bisecting, it seems that this bug was introduced by this commit: ckeditor/ckeditor5-table@281dba5

  • Browser: any
  • OS: any

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Mar 10, 2020
@Mgsy Mgsy added status:confirmed type:regression This issue reports a bug that was not present in the previous releases. labels Mar 10, 2020
@Reinmar Reinmar added this to the iteration 31 milestone Mar 24, 2020
@jodator
Copy link
Contributor

jodator commented Mar 25, 2020

@FilipTokarski Could you verify this? WFM here.

I would like also to verify what I see on the GIF: I can see that all the cells are grey besides the middle one - how this happens? I've tested it by:

  1. insert 3x3 table
  2. select last table cell and set heading columns (all table cells are grey)
  3. split middle table cell
  4. split the same table cell again
  5. move the selection to the new middle cell (as in your GIF)
  6. invoke delete row

It works for me now.

@FilipTokarski
Copy link
Member Author

The cells are grey because they have styling applied, they are not header rows/columns. Sorry for that, indeed it might have been misleading.

Anyway, I checked it once again and now it works for me too. I guess it has been fixed together with other changes in table, in latest release. I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

No branches or pull requests

5 participants