Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository links in subpackages documentation #6537

Closed
mlewand opened this issue Apr 2, 2020 · 3 comments
Closed

Update repository links in subpackages documentation #6537

mlewand opened this issue Apr 2, 2020 · 3 comments
Assignees
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@mlewand
Copy link
Contributor

mlewand commented Apr 2, 2020

There are multiple instances in each package where repository-related links are placed. These will naturally change after the migration so we need to be sure that they're correct.

Examples are:

Also it make sense to run a proper search/regexp over all files, including js files - maybe there are some links that should be replaced too.

Subtask of #6479.

@mlewand mlewand added the type:task This issue reports a chore (non-production change) and other types of "todos". label Apr 2, 2020
@mlewand mlewand added this to the iteration 31 milestone Apr 2, 2020
@mlewand
Copy link
Contributor Author

mlewand commented Apr 2, 2020

As for the change I think it make sense just to make i/6537 branches in each package with the changes and make one, sort-of, master pull request? This should make PR status maintenance easier.

@pomek
Copy link
Member

pomek commented Apr 8, 2020

@mlewand
Copy link
Contributor Author

mlewand commented Apr 28, 2020

Fixed in ckeditor/ckeditor5-core#220 and with merging i/6537 branch to each other package.

@mlewand mlewand closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

2 participants