Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions should not be selected on space #95

Closed
fredck opened this issue Mar 9, 2020 · 3 comments
Closed

Mentions should not be selected on space #95

fredck opened this issue Mar 9, 2020 · 3 comments
Labels
enhancement A possible enhancement of an existing feature. upstream Dependent/related to external issues

Comments

@fredck
Copy link
Contributor

fredck commented Mar 9, 2020

Currently, it is cumbersome to type issue numbers, for example, that may not be in the mentions list.

For example, due to the number of issues, the ckeditor/ckeditor5 repo doesn't load all of them in their mentions list but just the most relevant ones. If you want to mention issue #1, you simply type #1 (which opens up the mentions list, with issues over number 1000 listed). As soon you type space to continue writing, #1 is changed to the first issue in the list, because space is used to confirm the selected option.

We should replicate the GH behavior and confirm the selection exclusively on enter.
@fredck fredck added enhancement A possible enhancement of an existing feature. upstream Dependent/related to external issues labels Mar 9, 2020
@fredck
Copy link
Contributor Author

fredck commented Mar 9, 2020

Upstream issue, caused most likely by the following:
https://github.com/ckeditor/ckeditor5-mention/blob/9a514ccb0dc8b595100fd4459a82fa67cc329d1d/src/mentionui.js#L124

@fredck
Copy link
Contributor Author

fredck commented Mar 9, 2020

Upstream issue opened: ckeditor/ckeditor5#6394.

@fredck
Copy link
Contributor Author

fredck commented Mar 9, 2020

Fixed by ckeditor/ckeditor5-mention#92 and included in GitHub RTE by ckeditor/ckeditor5-mention@1e87fb9 in the github-rte branch.

@fredck fredck closed this as completed Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A possible enhancement of an existing feature. upstream Dependent/related to external issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fredck