fix: fail on target-init error

Signed-off-by: Christian Kotzbauer <[email protected]>
ckotzbauer · Oct 1, 2022 · 2601fea · 2601fea
1 parent 9363729
commit 2601fea
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 8 deletions.
diff --git a/internal/daemon/daemon.go b/internal/daemon/daemon.go
@@ -59,7 +59,11 @@ func (c *CronService) runBackgroundService() {
 
 	if !processor.HasJobImage() {
 		for _, t := range c.processor.Targets {
-			t.Initialize()
+			err := t.Initialize()
+			if err != nil {
+				logrus.Fatalf("Target could not be initialized: %w", err)
+			}
+
 			t.LoadImages()
 		}
 	}

diff --git a/internal/processor/processor.go b/internal/processor/processor.go
@@ -314,7 +314,10 @@ func (p *Processor) runInformerAsync(informer cache.SharedIndexInformer) {
 	go func() {
 		if !HasJobImage() {
 			for _, t := range p.Targets {
-				t.Initialize()
+				err := t.Initialize()
+				if err != nil {
+					logrus.Fatalf("Target could not be initialized: %w", err)
+				}
 			}
 		}
 

diff --git a/internal/target/configmap/configmap_target.go b/internal/target/configmap/configmap_target.go
@@ -24,7 +24,8 @@ func (g *ConfigMapTarget) ValidateConfig() error {
 	return nil
 }
 
-func (g *ConfigMapTarget) Initialize() {
+func (g *ConfigMapTarget) Initialize() error {
+	return nil
 }
 
 func (g *ConfigMapTarget) ProcessSbom(ctx *target.TargetContext) error {

diff --git a/internal/target/dtrack/dtrack_target.go b/internal/target/dtrack/dtrack_target.go
@@ -51,7 +51,8 @@ func (g *DependencyTrackTarget) ValidateConfig() error {
 	return nil
 }
 
-func (g *DependencyTrackTarget) Initialize() {
+func (g *DependencyTrackTarget) Initialize() error {
+	return nil
 }
 
 func (g *DependencyTrackTarget) ProcessSbom(ctx *target.TargetContext) error {

diff --git a/internal/target/git/git_target.go b/internal/target/git/git_target.go
@@ -61,8 +61,8 @@ func (g *GitTarget) ValidateConfig() error {
 	return nil
 }
 
-func (g *GitTarget) Initialize() {
-	g.gitAccount.PrepareRepository(g.repository, g.workingTree, g.branch)
+func (g *GitTarget) Initialize() error {
+	return g.gitAccount.PrepareRepository(g.repository, g.workingTree, g.branch)
 }
 
 func (g *GitTarget) ProcessSbom(ctx *target.TargetContext) error {

diff --git a/internal/target/oci/oci_target.go b/internal/target/oci/oci_target.go
@@ -48,7 +48,8 @@ func (g *OciTarget) ValidateConfig() error {
 	return nil
 }
 
-func (g *OciTarget) Initialize() {
+func (g *OciTarget) Initialize() error {
+	return nil
 }
 
 func (g *OciTarget) ProcessSbom(ctx *target.TargetContext) error {

diff --git a/internal/target/target.go b/internal/target/target.go
@@ -13,7 +13,7 @@ type TargetContext struct {
 }
 
 type Target interface {
-	Initialize()
+	Initialize() error
 	ValidateConfig() error
 	ProcessSbom(ctx *TargetContext) error
 	LoadImages() []*oci.RegistryImage