Skip to content

Commit

Permalink
fix: use empty array without a secret-name
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Kotzbauer <[email protected]>
  • Loading branch information
ckotzbauer committed Apr 27, 2022
1 parent 70e2fff commit 35a78e8
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion internal/kubernetes/kubernetes.go
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ func (client *KubeClient) CreateJob(namespace, suffix, image, pullSecrets string
},
},
RestartPolicy: corev1.RestartPolicyNever,
ImagePullSecrets: []corev1.LocalObjectReference{{Name: pullSecrets}},
ImagePullSecrets: createPullSecrets(pullSecrets),
Volumes: []corev1.Volume{
{
Name: "config",
Expand All @@ -315,6 +315,16 @@ func (client *KubeClient) CreateJob(namespace, suffix, image, pullSecrets string
return client.Client.BatchV1().Jobs(namespace).Create(context.Background(), j, meta.CreateOptions{})
}

func createPullSecrets(name string) []corev1.LocalObjectReference {
refs := make([]corev1.LocalObjectReference, 0)

if name != "" {
refs = append(refs, corev1.LocalObjectReference{Name: name})
}

return refs
}

func mapToEnvVars(m map[string]string) []corev1.EnvVar {
vars := make([]corev1.EnvVar, 0)
for k, v := range m {
Expand Down

0 comments on commit 35a78e8

Please sign in to comment.