cleanup: removed git-fallback-clone

Signed-off-by: Christian Kotzbauer <[email protected]>
ckotzbauer · Dec 23, 2022 · 5b736a8 · 5b736a8
1 parent 5f2645a
commit 5b736a8
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -159,7 +159,6 @@ The `autoCreate` option of DT is used. You have to set the `--format` flag to `c
 | `git-password` | `false` | `""` | Git-Password |
 | `github-app-id` | `false` | `""` | GitHub App-ID. |
 | `github-app-installation-id` | `false` | `""` | GitHub App-Installation-ID. |
-| `git-fallback-clone` | `false` | `false` | **Deprecated:**: Use git binary for clones. |
 
 The operator will save all files with a specific folder structure as described below. When a `git-path` is configured, all folders above this path are not touched
 from the application. Assuming that `git-path` is set to `dev-cluster/sboms`. When no `git-path` is given, the structure below is directly in the repository-root. 

diff --git a/internal/config.go b/internal/config.go
@@ -48,7 +48,6 @@ var (
 	ConfigKeyGitPassword             = "git-password"
 	ConfigKeyGitAuthorName           = "git-author-name"
 	ConfigKeyGitAuthorEmail          = "git-author-email"
-	ConfigKeyGitFallbackClone        = "git-fallback-clone"
 	ConfigKeyGitHubAppId             = "github-app-id"
 	ConfigKeyGitHubAppInstallationId = "github-app-installation-id"
 	ConfigKeyPodLabelSelector        = "pod-label-selector"

diff --git a/main.go b/main.go
@@ -66,7 +66,6 @@ func newRootCmd() *cobra.Command {
 	rootCmd.PersistentFlags().String(internal.ConfigKeyGitAuthorEmail, "", "Author email to use for Git-Commits.")
 	rootCmd.PersistentFlags().String(internal.ConfigKeyGitHubAppId, "", "GitHub App ID (for authentication).")
 	rootCmd.PersistentFlags().String(internal.ConfigKeyGitHubAppInstallationId, "", "GitHub App Installation ID (for authentication).")
-	rootCmd.PersistentFlags().Bool(internal.ConfigKeyGitFallbackClone, false, "Use git binary for clones.")
 	rootCmd.PersistentFlags().String(internal.ConfigKeyPodLabelSelector, "", "Kubernetes Label-Selector for pods.")
 	rootCmd.PersistentFlags().String(internal.ConfigKeyNamespaceLabelSelector, "", "Kubernetes Label-Selector for namespaces.")
 	rootCmd.PersistentFlags().String(internal.ConfigKeyDependencyTrackBaseUrl, "", "Dependency-Track base URL, e.g. 'https://dtrack.example.com'")
@@ -82,11 +81,6 @@ func newRootCmd() *cobra.Command {
 	rootCmd.PersistentFlags().String(internal.ConfigKeyOciUser, "", "OCI-User")
 	rootCmd.PersistentFlags().String(internal.ConfigKeyOciToken, "", "OCI-Token")
 
-	err := rootCmd.PersistentFlags().MarkDeprecated(internal.ConfigKeyGitFallbackClone, "'multi_ack' is supported by default. The flag doesn't have any effect and will be removed in 0.24.0")
-	if err != nil {
-		panic(err)
-	}
-
 	return rootCmd
 }