Don't continue if list namespaces failes

We had some networking issues in our cluster. This caused a ListNamespaces to fail. This caused the sbom-operator to delete all sboms in our git directory.

internal/daemon/daemon.go

@@ -67,7 +67,12 @@ func (c *CronService) runBackgroundService() {
 	}
 
 	k8s := kubernetes.NewClient()
-	namespaces := k8s.ListNamespaces(viper.GetString(internal.ConfigKeyNamespaceLabelSelector))
+	namespaceSelector := viper.GetString(internal.ConfigKeyNamespaceLabelSelector)
+	namespaces, err := k8s.ListNamespaces(namespaceSelector)
+	if err != nil {
+		logrus.WithError(err).Errorf("failed to list namespaces with selector: %s, abort background-service", namespaceSelector)
+		return
+	}
 	logrus.Debugf("Discovered %v namespaces", len(namespaces))
 	containerImages, allImages := k8s.LoadImageInfos(namespaces, viper.GetString(internal.ConfigKeyPodLabelSelector))
 

internal/kubernetes/kubernetes.go

@@ -66,34 +66,36 @@ func prepareLabelSelector(selector string) meta.ListOptions {
 	return listOptions
 }
 
-func (client *KubeClient) ListNamespaces(labelSelector string) []corev1.Namespace {
+func (client *KubeClient) ListNamespaces(labelSelector string) ([]corev1.Namespace, error) {
 	list, err := client.Client.CoreV1().Namespaces().List(context.Background(), prepareLabelSelector(labelSelector))
 
 	if err != nil {
-		logrus.WithError(err).Error("ListNamespaces errored!")
-		return []corev1.Namespace{}
+		return []corev1.Namespace{}, fmt.Errorf("failed to list namespaces")
 	}
 
-	return list.Items
+	return list.Items, nil
 }
 
-func (client *KubeClient) listPods(namespace, labelSelector string) []corev1.Pod {
+func (client *KubeClient) listPods(namespace, labelSelector string) ([]corev1.Pod, error) {
 	list, err := client.Client.CoreV1().Pods(namespace).List(context.Background(), prepareLabelSelector(labelSelector))
 
 	if err != nil {
-		logrus.WithError(err).Error("ListPods errored!")
-		return []corev1.Pod{}
+		return []corev1.Pod{}, fmt.Errorf("failed to list pods: %w", err)
 	}
 
-	return list.Items
+	return list.Items, nil
 }
 
 func (client *KubeClient) LoadImageInfos(namespaces []corev1.Namespace, podLabelSelector string) (map[string]ContainerImage, []ContainerImage) {
 	images := map[string]ContainerImage{}
 	allImages := []ContainerImage{}
 
 	for _, ns := range namespaces {
-		pods := client.listPods(ns.Name, podLabelSelector)
+		pods, err := client.listPods(ns.Name, podLabelSelector)
+		if err != nil {
+			logrus.WithError(err).Errorf("failed to list pods for namespace: %s", ns.Name)
+			continue
+		}
 
 		for _, pod := range pods {
 			annotations := pod.Annotations

internal/target/dtrack_target.go

@@ -65,7 +65,11 @@ func (g *DependencyTrackTarget) ProcessSbom(image kubernetes.ContainerImage, sbo
 		return nil
 	}
 
-	client, _ := dtrack.NewClient(g.baseUrl, dtrack.WithAPIKey(g.apiKey))
+	client, err := dtrack.NewClient(g.baseUrl, dtrack.WithAPIKey(g.apiKey))
+	if err != nil {
+		logrus.WithError(err).Errorf("failed to init dtrack client")
+		return err
+	}
 
 	logrus.Infof("Sending SBOM to Dependency Track (project=%s, version=%s)", projectName, version)