Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Open Type Hierarchy" menu should be hidden when clangd crashes #68

Closed
hokein opened this issue Sep 9, 2020 · 1 comment · Fixed by #73
Closed

"Open Type Hierarchy" menu should be hidden when clangd crashes #68

hokein opened this issue Sep 9, 2020 · 1 comment · Fixed by #73
Assignees
@HighCommander4
Labels
bug Something isn't working

Comments

@hokein
Copy link
Collaborator

hokein commented Sep 9, 2020

Other menus ("go to definition" etc) are hidden when clangd crashes, I think we should align with them.
@hokein hokein added the bug Something isn't working label Sep 9, 2020
@HighCommander4 HighCommander4 self-assigned this Sep 20, 2020
HighCommander4 added a commit to HighCommander4/vscode-clangd that referenced this issue Sep 20, 2020
@HighCommander4
Only show the 'Open Type Hierarchy' context menu item when the server…
83c1109 
… is running

Fixes clangd#68
@HighCommander4 HighCommander4 mentioned this issue Sep 20, 2020
Merged
@HighCommander4
Copy link
Contributor

Proposed fix

hokein pushed a commit that referenced this issue Sep 29, 2020
@HighCommander4
Only show the 'Open Type Hierarchy' context menu item when the server… (
d6399f6 
#73)

* Only show the 'Open Type Hierarchy' context menu item when the server is running

Fixes #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HighCommander4 HighCommander4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@HighCommander4 @hokein