Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IBC Go #86

Closed
4 tasks done
LuncBurner opened this issue Feb 2, 2023 · 5 comments · Fixed by #93
Closed
4 tasks done

Update IBC Go #86

LuncBurner opened this issue Feb 2, 2023 · 5 comments · Fixed by #93
Assignees
@fragwuerdig @ZaradarBH
Labels
enhancement New feature or request out of scope work that is unapproved by the community, but still essential for the L1 team security Security concerns
Milestone
Core - v1.1.0

Comments

@LuncBurner
Copy link

LuncBurner commented Feb 2, 2023 •
edited by ZaradarBH
Loading

Problem definition
The current IBC version is outdated. We need to update the IBC-GO module to version 1.3.1

Feature specification

  • Undertake research on Juno
  • Implement the needed changes
  • Testing on local net

Additional context
.

Acceptance Criteria

  • Successfully upgrade to 1.3.1 and confirm correct functionality
@LuncBurner LuncBurner added the enhancement New feature or request label Feb 2, 2023
@LuncBurner LuncBurner added this to the v2.0.4 milestone Feb 2, 2023
@ZaradarBH ZaradarBH moved this to 🆕 New in L1 Task Force - Backlog Feb 5, 2023
@LuncBurner LuncBurner modified the milestones: v2.0.4, v1.0.6 Feb 6, 2023
@ZaradarBH ZaradarBH self-assigned this Feb 7, 2023
@ZaradarBH ZaradarBH moved this from 🔖 Ready to 🏗 In progress in L1 Sprint #3 Feb 6th - Feb 17th Feb 7, 2023
@ZaradarBH
Copy link
Contributor

#93

@ZaradarBH ZaradarBH added out of scope work that is unapproved by the community, but still essential for the L1 team security Security concerns labels Feb 7, 2023
@ZaradarBH ZaradarBH linked a pull request Feb 7, 2023 that will close this issue
Upgrade to golang 1.18 and fix ad-hoc security vulnerabilities #93
Merged
4 tasks
@ZaradarBH
Copy link
Contributor

@fragwuerdig I updated the dependencies in the PR above. If you can find time to test it vs rebel-2 that would be epic. Also I am not sure what research we are doing on Juno?

@fragwuerdig
Copy link
Collaborator

fragwuerdig commented Feb 8, 2023 •
edited
Loading

Can we test this on rebel-2 as soon as we have a release candidate for 1.0.6? I would prefer to check that particular branch against a local net. We should really only test RCs against rebel-2, imho.

You can remove that Juno research thing. I Just wanted to learn how to upgrade that particular dependency.

@ZaradarBH ZaradarBH moved this from 🏗 In progress to 👀 In review in L1 Sprint #3 Feb 6th - Feb 17th Feb 9, 2023
@inon-man
Copy link
Collaborator

Can we test this on rebel-2 as soon as we have a release candidate for 1.0.6? I would prefer to check that particular branch against a local net. We should really only test RCs against rebel-2, imho.

You can remove that Juno research thing. I Just wanted to learn how to upgrade that particular dependency.

Could you please tell me what rebel-2 is? Sorry.

@fragwuerdig
Copy link
Collaborator

@inon-man: That's the testnet. Please have a look into the slack server channel #testnet.

@ZaradarBH ZaradarBH added enhancement New feature or request and removed enhancement New feature or request labels Feb 15, 2023
@ZaradarBH ZaradarBH moved this to 👀 In review in L1 Sprint #4 Feb 20th - Mar 3rd Feb 17, 2023
@ZaradarBH ZaradarBH moved this from 👀 In review to ✅ Done in L1 Sprint #4 Feb 20th - Mar 3rd Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fragwuerdig fragwuerdig

@ZaradarBH ZaradarBH

Labels
enhancement New feature or request out of scope work that is unapproved by the community, but still essential for the L1 team security Security concerns
Projects
No open projects
L1 Sprint #4 Feb 20th - Mar 3rd
Status: ✅ Done
Milestone
Core - v1.1.0
Development

Successfully merging a pull request may close this issue.

Upgrade to golang 1.18 and fix ad-hoc security vulnerabilities classic-terra/core
4 participants
@fragwuerdig @ZaradarBH @LuncBurner @inon-man