Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join API causes memory leak in React SPA #1239

Closed
ruslan-shuster opened this issue Jan 6, 2020 · 2 comments
Closed

Join API causes memory leak in React SPA #1239

ruslan-shuster opened this issue Jan 6, 2020 · 2 comments

Comments

@ruslan-shuster
Copy link

We have a single-page react application using rappid and joint libraries. The components that use rappid functionality are not being garbage-collected. When I investigated memory snapshots I see that the object roots are in SVG-prefixed 'window' properties. What can I do to prevent such behaviour? We use rappid version 2.4.0(joint 2.2.1).
Screen Shot 2020-01-04 at 14 23 09

@kumilingus
Copy link
Contributor

It is necessary to call remove() method on every mvc.View in order to dispose it properly.

@LouisSung
Copy link

LouisSung commented Jan 19, 2020

Sorry for asking question here rather than new an issue. (I'll do so if necessary)
Actually, I am facing similar memory leaks issue recently.

I'm using Angular 8 rather than the React. (and JointJS 3.1.1)
In my case, I do add paper.remove() and print logs in ngOnDestory(), which means those papers should have called remove() correctly when route to other pages.
However, there are still thousand of leaks here and I don't know how to fix it... (I even call graph.clear() at the same time but still don't work)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants