fix: 修复navigation-timing中有值小于0时，不做上报处理，FP和FCP在页面隐藏后不做上报处理

clouDr-f2e · Sep 24, 2021 · 8d0280b · 8d0280b
1 parent e1c1610
commit 8d0280b
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 7 deletions.
diff --git a/packages/web-performance/src/metrics/getFCP.ts b/packages/web-performance/src/metrics/getFCP.ts
@@ -9,6 +9,7 @@ import { roundByFour } from '../utils'
 import { metricsName } from '../constants'
 import metricsStore from '../lib/store'
 import observe from '../lib/observe'
+import getFirstHiddenTime from '../lib/getFirstHiddenTime'
 
 const getFCP = (): Promise<PerformanceEntry> | undefined => {
   if (!isPerformanceObserverSupported()) {
@@ -23,7 +24,9 @@ const getFCP = (): Promise<PerformanceEntry> | undefined => {
           po.disconnect()
         }
 
-        resolve(entry)
+        if (entry.startTime < getFirstHiddenTime().timeStamp) {
+          resolve(entry)
+        }
       }
     }
 

diff --git a/packages/web-performance/src/metrics/getFP.ts b/packages/web-performance/src/metrics/getFP.ts
@@ -9,6 +9,7 @@ import { roundByFour } from '../utils'
 import { metricsName } from '../constants'
 import metricsStore from '../lib/store'
 import observe from '../lib/observe'
+import getFirstHiddenTime from '../lib/getFirstHiddenTime'
 
 const getFP = (): Promise<PerformanceEntry> | undefined => {
   if (!isPerformanceObserverSupported()) {
@@ -23,7 +24,9 @@ const getFP = (): Promise<PerformanceEntry> | undefined => {
           po.disconnect()
         }
 
-        resolve(entry)
+        if (entry.startTime < getFirstHiddenTime().timeStamp) {
+          resolve(entry)
+        }
       }
     }
 

diff --git a/packages/web-performance/src/metrics/getNavigationTiming.ts b/packages/web-performance/src/metrics/getNavigationTiming.ts
@@ -18,7 +18,7 @@ import { isPerformanceSupported, isPerformanceObserverSupported } from '../utils
 import { metricsName } from '../constants'
 import metricsStore from '../lib/store'
 import observe from '../lib/observe'
-import { roundByFour } from '../utils'
+import { roundByFour, validNumber } from '../utils'
 
 const getNavigationTiming = (): Promise<IPerformanceNavigationTiming> | undefined => {
   if (!isPerformanceSupported()) {
@@ -88,10 +88,12 @@ export const initNavigationTiming = (store: metricsStore, report: IReportHandler
   getNavigationTiming()?.then((navigationTiming) => {
     const metrics = { name: metricsName.NT, value: navigationTiming } as IMetrics
 
-    if (immediately) {
-      report(metrics)
-    }
+    if (validNumber(Object.values(metrics.value))) {
+      if (immediately) {
+        report(metrics)
+      }
 
-    store.set(metricsName.NT, metrics)
+      store.set(metricsName.NT, metrics)
+    }
   })
 }
diff --git a/packages/web-performance/src/utils/index.ts b/packages/web-performance/src/utils/index.ts
@@ -28,3 +28,11 @@ export const beforeUnload = (callback) => {
 export const unload = (callback) => {
   window.addEventListener('unload', callback)
 }
+
+export const validNumber = (nums: number | Array<number>) => {
+  if (Array.isArray(nums)) {
+    return nums.every((n) => n >= 0)
+  } else {
+    return nums >= 0
+  }
+}