This repository has been archived by the owner on Mar 11, 2022. It is now read-only.
mdk/Fix multipart replicator hang #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. |
|
+1 merging |
rhyshort
added a commit
that referenced
this pull request
Nov 3, 2015
mdk/Fix multipart replicator hang
|
@mkistler This has been released in 0.19.2, thanks for the hard work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with multipart uploads that was exposed by CDTIncrementalStore.
The problem was introduced in 0.19.0 and traced down to the conversion from NSURLConnection to NSURLSession. In a nutshell, the TDMultipartUploader maintains a queue of uploads to be processed and used the connectionDidFinishLoading: delegate method of NSURLConnection to initiate the next upload. In the conversion to NSURLSession, this delegate method is no longer called and no provision was made to trigger subsequent uploads through another means.
This PR adds a simple receivedData: method to TDMultipartUploader to trigger subsequent uploads. This is consistent with the change made to TDRemoteJSONRequest which signals that its processing is complete in its receivedData: method.
This PR includes a test case in the ReplicationAcceptance test suite to reproduce the problem (prior to the fix) and verifies the fix.