Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the instances/list API for GoogleComputeProvider.find() instead of instances/get #124

Open
mdwn opened this issue Dec 5, 2016 · 0 comments

Comments

@mdwn
Copy link
Contributor

mdwn commented Dec 5, 2016

According to https://cloud.google.com/compute/docs/api-rate-limits, Google Cloud's API rate limit is 20 requests/second. I noticed that, in GoogleComputeProvider.find(), the code currently iterates through the list of given IDs and gets one instance at a time. Given the API rate limit, this may be problematic. https://cloud.google.com/compute/docs/reference/latest/instances/list may be a better choice.

I realize that this may not be possible since list is a GET request only, or may be painful due to GET request sizes. Still, I think this is worth investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant