We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
purego
golang/go#23172 proposes the de-facto purego build tag.
circl uses both purego and noasm build tags, inconsistently.
circl
noasm
If a user wants a purego build, the build should not include assembly.
Would circl be willing to align on purego meaning noasm?
For example, this is what the upstream golang crypto package does: https://go-review.googlesource.com/c/go/+/561935
crypto
Another option is to make purego and noasm equivalent in the code-base if noasm needs to be a backwards supported build flag.
I would be willing to contribute the patch.
The text was updated successfully, but these errors were encountered:
pure = "on"
[email protected]
@mattyclarkson thanks for raising this issue, happy to review your patch.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
golang/go#23172 proposes the de-facto
purego
build tag.circl
uses bothpurego
andnoasm
build tags, inconsistently.If a user wants a
purego
build, the build should not include assembly.Would
circl
be willing to align onpurego
meaningnoasm
?For example, this is what the upstream golang
crypto
package does: https://go-review.googlesource.com/c/go/+/561935Another option is to make
purego
andnoasm
equivalent in the code-base ifnoasm
needs to be a backwards supported build flag.I would be willing to contribute the patch.
The text was updated successfully, but these errors were encountered: