-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize next-dev
's DevBindingsOptions
API (and remove __experimental__
prefix)
#527
Labels
blocked by external
This can't be currently solved because of external factors (Vercel/Next, Pages, etc...)
Comments
next-dev
's DevBindingsOptions
API before the next stable releasenext-dev
's DevBindingsOptions
API (and remove __experimental__
prefix)
I think we should follow Wrangler's new API here |
TODO after changing the API:
|
Note: the new Wrangler API accepts |
I've added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked by external
This can't be currently solved because of external factors (Vercel/Next, Pages, etc...)
In #486 we've added the
next-dev
submodule for adding local bindings to next dev.The submodule exports the
setupDevBindings
function which accepts aDevBindingsOptions
object for the various options.Most of the options there follow Miniflare's API with the exception of
textBindings
(which in Miniflare is justbindings
), adding a new term there could be worse/more confusing then just sticking with the (potentially confusing)bindings
term (see #486 (comment)).So before our next release we need to decide how the
DevBindingsOptions
object needs to look like, the alternatives are:textBindings
withbindings
(to align it more with Miniflare)The text was updated successfully, but these errors were encountered: