Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: remove async-trait #509

Open
Congyuwang opened this issue Jan 10, 2025 · 2 comments
Open

Performance: remove async-trait #509

Congyuwang opened this issue Jan 10, 2025 · 2 comments
Assignees
@Noah-Kennedy
Labels
dependencies Pull requests that update a dependency file

Comments

@Congyuwang
Copy link
Contributor

Congyuwang commented Jan 10, 2025 •
edited
Loading

Since async trait is now stable in rust. We can think of removing relying on the the async-trait macro, which requires returning Boxed Future which is less efficient than using rust native async trait.
@Congyuwang Congyuwang changed the title Remove async-trait Performance: remove async-trait Jan 10, 2025
@gumpt gumpt added dependencies Pull requests that update a dependency file Long Term Goal Feature that we plan to support but not likely in the near future and removed Long Term Goal Feature that we plan to support but not likely in the near future labels Jan 17, 2025
@taikulawo
Copy link
Contributor

Unless use generic to generate nested HttpModules at compile time. Current Rust AFIT isn't dyn compatible, so Box not works.

@Congyuwang
Copy link
Contributor Author

Unless use generic to generate nested HttpModules at compile time. Current Rust AFIT isn't dyn compatible, so Box not works.

Oh right, that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Noah-Kennedy Noah-Kennedy

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gumpt @Noah-Kennedy @taikulawo @Congyuwang