resource/cloudflare_origin_ca: ignore decreasing requested_validity
#1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an optional field and not required for anything other than new resources so it's fine to suppress all diffs for the field. Closes #1031
2 tasks
jacobbednarz
added a commit
that referenced
this pull request
Sep 22, 2021
…changes In #1078 we shipped a change that would ignore the `requested_validity` attribute as it is an ever decreasing value that shouldn't trigger a change. However, digging into this has surfaced a bug in `terraform-plugin-sdk`[1] that is preventing the schema from providing the value to the CRUD method due to the presence of `DiffSuppressFunc`. Instead of using a `DiffSuppressFunc`, mark the attribute as Optional and Computed to allow it to be ignored when it decreases. ``` === RUN TestAccCloudflareOriginCACertificate_Basic resource_cloudflare_origin_ca_certificate_test.go:34: Step 1/2 error: Check failed: Check 6/6 error: cloudflare_origin_ca_certificate.mjrtkutxmm: Attribute 'requested_validity' expected "7", got "5475" ``` Closes #1160 [1]: hashicorp/terraform-plugin-sdk#806
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional field and not required for anything other than new
resources so it's fine to suppress all diffs for the field.
Closes #1031