Add support for cloudflare_custom_pages resource
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jacobbednarz
force-pushed
the
add-custom-pages-resource
branch
from
3572050 to
0880d57
Compare
|
Vendoring update is happening in #137 |
This introduces support for managing the custom error pages as a Terraform resource. Depends on cloudflare/cloudflare-go#240 however I will wait for that to land and then propose a PR that updates the vendored library in a separate PR.
jacobbednarz
force-pushed
the
add-custom-pages-resource
branch
from
0880d57 to
3ea2f64
Compare
|
Have rebased master into this branch. CI should be green now. |
|
Looks good, thanks Jacob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for managing the custom error pages as a
Terraform resource.
Website
Sidebar
Content
Depends on cloudflare/cloudflare-go#240 however I will wait for that to
land and then propose a PR that updates the vendored library in a
separate PR.