Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruleset support for rewriting response headers #1339

Merged
merged 2 commits into from
Dec 11, 2021
Merged

Ruleset support for rewriting response headers #1339

merged 2 commits into from
Dec 11, 2021

Conversation

jacobbednarz
Copy link
Member

Adds support and documentation for http_response_headers_transform phase.

Includes a new sweeper for Rulesets to ensure dangling Rulesets are cleaned up before each run.

Closes #1317

@jacobbednarz
Copy link
Member Author

acceptance tests are passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareRuleset_TransformationRule" -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareRuleset_TransformationRuleURIPath
=== PAUSE TestAccCloudflareRuleset_TransformationRuleURIPath
=== RUN   TestAccCloudflareRuleset_TransformationRuleURIQuery
=== PAUSE TestAccCloudflareRuleset_TransformationRuleURIQuery
=== RUN   TestAccCloudflareRuleset_TransformationRuleURIPathAndQueryCombination
=== PAUSE TestAccCloudflareRuleset_TransformationRuleURIPathAndQueryCombination
=== RUN   TestAccCloudflareRuleset_TransformationRuleRequestHeaders
=== PAUSE TestAccCloudflareRuleset_TransformationRuleRequestHeaders
=== RUN   TestAccCloudflareRuleset_TransformationRuleResponseHeaders
=== PAUSE TestAccCloudflareRuleset_TransformationRuleResponseHeaders
=== CONT  TestAccCloudflareRuleset_TransformationRuleURIPath
--- PASS: TestAccCloudflareRuleset_TransformationRuleURIPath (10.29s)
=== CONT  TestAccCloudflareRuleset_TransformationRuleRequestHeaders
--- PASS: TestAccCloudflareRuleset_TransformationRuleRequestHeaders (11.54s)
=== CONT  TestAccCloudflareRuleset_TransformationRuleResponseHeaders
--- PASS: TestAccCloudflareRuleset_TransformationRuleResponseHeaders (9.76s)
=== CONT  TestAccCloudflareRuleset_TransformationRuleURIPathAndQueryCombination
--- PASS: TestAccCloudflareRuleset_TransformationRuleURIPathAndQueryCombination (12.31s)
=== CONT  TestAccCloudflareRuleset_TransformationRuleURIQuery
--- PASS: TestAccCloudflareRuleset_TransformationRuleURIQuery (11.66s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	55.790s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz force-pushed the ruleset-support-for-rewriting-headers branch from b79524c to 674b1c9 Compare December 11, 2021 20:07
@jacobbednarz jacobbednarz merged commit ba70ea1 into master Dec 11, 2021
@jacobbednarz jacobbednarz deleted the ruleset-support-for-rewriting-headers branch December 11, 2021 22:22
github-actions bot pushed a commit that referenced this pull request Dec 11, 2021
Update CHANGELOG.md for #1339
04e6520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update cloudflare_ruleset resource to support for response header modifications
1 participant
@jacobbednarz