Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of zone lockdowns #135

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Oct 24, 2018

As mentioned in #134, zone lockdowns imports are failing, and the regression is caused by hashicorp@4bc4aa2#diff-0e4cc11a1763d8ef0318546d3027d928

Sadly, I do not have a test account with the appropriate subscription level to run the acceptance tests:

                * cloudflare_zone_lockdown.zuwfrow271: error creating zone lockdown for zone "myzone.org": error from makeRequest: HTTP status 400: content "{\n  \"result\": null,\n  \"success\": false,\n  \"errors\": [\n    {\n      \"code\": 10012,\n      \"messag
e\": \"zonelockdown.api.not_entitled.max_rules\"\n    }\n  ],\n  \"messages\": []\n}\n"                                                                                                                                                                                  

(and I'd rather not run acceptance tests on production accounts)

@ghost ghost added the size/XS label Oct 24, 2018
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! 🌟 I have confirmed that this change addresses the issue. Thanks!

@patryk
Copy link
Contributor

patryk commented Oct 24, 2018

Ops! Sorry about that. Just how one missing line can break things. Thanks for the effort.

@patryk patryk merged commit 61c97e1 into cloudflare:master Oct 24, 2018
@pdecat pdecat deleted the fix-zonelockdown-import branch October 24, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants