GATE-2386: Adds support for missing team rules settings #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for creating rules with session management settings (check_session), adding HTTP headers (add_headers), and other missing browser isolation options.
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example: If you do not require a release note to be included, please add the |
| @@ -44,6 +44,8 @@ func TestAccCloudflareTeamsRuleBasic(t *testing.T) { | |||
| resource.TestCheckResourceAttr(name, "traffic", "any(dns.domains[*] == \"example.com\")"), | |||
| resource.TestCheckResourceAttr(name, "rule_settings.0.block_page_enabled", "false"), | |||
| resource.TestCheckResourceAttr(name, "rule_settings.0.block_page_reason", "cuz"), | |||
| resource.TestCheckResourceAttr(name, "rule_settings.0.check_session.enforce", "true"), | |||
| resource.TestCheckResourceAttr(name, "rule_settings.0.check_session.duration", "200s"), | |||
There was a problem hiding this comment.
something is up here; the acceptance tests aren't passing
TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTeamsRule" -count 1 -parallel 1 -timeout 120m -parallel 1
? github.com/cloudflare/terraform-provider-cloudflare [no test files]
=== RUN TestAccCloudflareTeamsRuleBasic
resource_cloudflare_teams_rules_test.go:28: Step 1/1 error: Error running apply: exit status 1
Error: error creating Teams rule for account "f037e56e89293a057740de681ac9abbe": HTTP status 400: EOF
with cloudflare_teams_rule.qgngjyuhan,
on terraform_plugin_test.tf line 2, in resource "cloudflare_teams_rule" "qgngjyuhan":
2: resource "cloudflare_teams_rule" "qgngjyuhan" {
--- FAIL: TestAccCloudflareTeamsRuleBasic (8.24s)
FAIL
FAIL github.com/cloudflare/terraform-provider-cloudflare/cloudflare 8.818s
? github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check [no test files]
? github.com/cloudflare/terraform-provider-cloudflare/version [no test files]
FAIL
make: *** [testacc] Error 1
Comment on lines
47
to
48
| resource.TestCheckResourceAttr(name, "rule_settings.0.check_session.enforce", "true"), | ||
| resource.TestCheckResourceAttr(name, "rule_settings.0.check_session.duration", "200s"), |
There was a problem hiding this comment.
Suggested change
| resource.TestCheckResourceAttr(name, "rule_settings.0.check_session.enforce", "true"), | |
| resource.TestCheckResourceAttr(name, "rule_settings.0.check_session.duration", "200s"), | |
| resource.TestCheckResourceAttr(name, "rule_settings.0.check_session.0.enforce", "true"), | |
| resource.TestCheckResourceAttr(name, "rule_settings.0.check_session.0.duration", "200s"), |
|
acceptance tests look good! once we update the website documentation to include the new fields, we can merge this. |
|
acceptance tests are now passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating rules with session management
settings (check_session), adding HTTP headers (add_headers), and other
missing browser isolation options.
This PR depends on cloudflare/cloudflare-go#786