-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/cloudflare_ruleset: Yet Another tristate bool fix #1405
Merged
jacobbednarz
merged 1 commit into
master
from
yet-another-tristate-bool-fix-for-rulesets
Jan 24, 2022
Merged
resource/cloudflare_ruleset: Yet Another tristate bool fix #1405
jacobbednarz
merged 1 commit into
master
from
yet-another-tristate-bool-fix-for-rulesets
Jan 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
force-pushed
the
yet-another-tristate-bool-fix-for-rulesets
branch
from
January 24, 2022 00:54
2dc7cae
to
0faaf3b
Compare
2 tasks
jacobbednarz
force-pushed
the
yet-another-tristate-bool-fix-for-rulesets
branch
from
January 24, 2022 00:56
0faaf3b
to
3fec904
Compare
Updates the check for whether or not to populate the `enabled` flag on category/rule based overrides to use the `GetOkExists` method (not recommended due to undocumented edge cases) to check the existence before converting the pointer to a value. Closes #1403
jacobbednarz
force-pushed
the
yet-another-tristate-bool-fix-for-rulesets
branch
from
January 24, 2022 01:03
46ea586
to
54c88a1
Compare
acceptance tests (including the updated one) are all passing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the check for whether or not to populate the
enabled
flag oncategory/rule based overrides to use the
GetOkExists
method (notrecommended due to undocumented edge cases) to check the existence
before converting the pointer to a value.
Closes #1403